-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from Class to Functional Components(Week.jsx) file. #5833
Open
abhay-dev2901
wants to merge
9
commits into
WikiEducationFoundation:master
Choose a base branch
from
abhay-dev2901:wiki-edu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migration from Class to Functional Components(Week.jsx) file. #5833
abhay-dev2901
wants to merge
9
commits into
WikiEducationFoundation:master
from
abhay-dev2901:wiki-edu
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please include screenshots, and do not include unrelated changes to schema.rb in the PR. |
OK sir I will fix it |
…in week.jsx able to merge
This still includes changes to unrelated files. |
Plz check now Sir |
Hello @ragesoss , Please review this PR |
Looks like there's an error that breaks the JS tests. |
@ragesoss Please review this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
This PR refactors the
Week.jsx
component from a class-based component to a functional component using React hooks. It maintains all the original functionalities while following the latest React guidelines. The changes include:useState
anduseEffect
hooks to manage state and side effects.This refactor addresses issues related to outdated React practices and aims to improve the performance and readability of the code.
Screenshots
Before:
After:
Open questions and concerns