Refactor: Migrate GetHelpButton from Class-Based to Functional Component #5847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please include before/after screenshots. |
|
@ragesoss sir, while migrating the code to functional components, I encountered a issue, there are two functions named getKey and stop which are not being used in this component so they are causing eslint error. Additionally, another error occurred due to missing I18n translations because in the original code they don't have used it. Please guide me on that. |
|
The eslint errors are breaking the build, and you should identify how to fix them. If the functions are not being used now, and they were before, then removing the unused functions should be part of the refactor. The i18n warnings will not cause the build to fail, and you can ignore those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the GetHelpButton component from a class-based component to a functional component.
Open questions and concerns
Please let me know if there is anything missing as I am new to open source.
before changes
WhatsApp.Video.2024-07-08.at.20.13.46.mp4
after changes
get.help.after.mp4