Course creator #5852
Open
Course creator #5852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should only include changes to the file for the one component that is being refactored. Also please include before/after screenshots. |
|
Hello @ragesoss Plz review this PR |
|
@ragesoss please review this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process
##What this PR does
<This pull request migrates the CourseCreator component from a class-based component to a functional component using React hooks. The purpose of this change is to modernize the component, simplify state management, and improve code readability. This PR addresses the issue of outdated React patterns in the CourseCreator component.>
##Screenshots
Before:
https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/149485820/f8f84f46-f5cf-4930-b992-d9d92fa61b7f
After:
WhatsApp.Video.2024-07-05.at.7.52.16.PM.mp4
##Open questions and concerns
<I learned that the lifecycle methods in class components can be effectively replaced with useEffect hooks in functional components, improving code readability and maintainability.
One concern is ensuring that all functionalities are preserved after the conversion. Thorough testing is necessary to verify that the component behaves as expected in all scenarios.
Are there any performance implications to consider with the new implementation, especially related to the useEffect hooks and state management?>