Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Refactor AdminUser component from createReactClass to functional com… #5871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yash121l
Copy link

What this PR does

This PR refactors the "AdminUser" component from createReactClass to a functional component. This will help towards aims to modernize the codebase and improve the performance and readability of the component.

Screenshots

Before:

WhatsApp.Video.2024-06-30.at.23.37.46.mp4

After:

WhatsApp.Video.2024-06-30.at.23.38.42.mp4

Open questions and concerns

  • During the refactor, I ensured that the component's behavior remains the same. However, it would be great to have a thorough review to catch any potential edge cases I might have missed.
  • I'm wondering if there are any additional hooks or patterns we should adopt to further enhance the functionality or performance of this component.

@ragesoss
Copy link
Member

Looks like the specs are failing related to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants