Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated course_creation_settings_form.jsx with latest react Rules #5874

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhay-dev2901
Copy link

##What this PR does
This PR updates the CourseCreationSettingsForm.jsx component to comply with the latest React rules and best practices.

##The main changes include:

  1. Refactoring the component to use React hooks (useState and useEffect) for managing state and side effects.
  2. Ensuring the form state is correctly synchronized with the incoming settings prop.
  3. Adding PropTypes to enforce the expected types for the component props.

##Issue Addressed
This PR addresses issue by ensuring the CourseCreationSettingsForm component is up-to-date with the latest React standards, improving maintainability and readability.

Screenshots
Before:
WhatsApp Image 2024-07-01 at 6 41 30 PM

After:
WhatsApp Image 2024-07-01 at 6 41 58 PM

##Open questions and concerns
Is there any specific validation required for the form inputs that should be added?
Are there additional fields that need to be included in the form based on recent changes or requirements?
Are there any performance implications of using hooks in this particular component that should be considered?

@ragesoss
Copy link
Member

ragesoss commented Jul 1, 2024

These screenshots are not showing the updated component. It is part of the /settings view.

@abhay-dev2901
Copy link
Author

@ragesoss Please look at to this PR once

@ragesoss
Copy link
Member

See my comment above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants