Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code migration. #5881

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

FreakForever
Copy link

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

< describe the purpose of this pull request and note the issue it addresses >
The respective pr changes the existing class component to modern react ie. to functional component using hooks.

Screenshots

Before:
< add a screenshot of the UI before your change >
WhatsApp July 2 Image (1)

After:
< add a screenshot of the UI after your change >

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >
WhatsApp July 3 Image

@FreakForever FreakForever marked this pull request as draft July 5, 2024 15:54
@FreakForever FreakForever marked this pull request as ready for review July 5, 2024 16:14
@FreakForever
Copy link
Author

FreakForever commented Jul 5, 2024

Hey @ragesoss, Please review my pr and let me know if any further changes are required.

@FreakForever
Copy link
Author

Hey @ragesoss I have made the required changes.

@ragesoss
Copy link
Member

ragesoss commented Jul 9, 2024

It looks like the failing specs are related to this component.

@FreakForever FreakForever marked this pull request as draft July 10, 2024 03:28
@FreakForever FreakForever marked this pull request as ready for review July 11, 2024 12:13
@FreakForever
Copy link
Author

Hey @ragesoss I have made the required changes.

@FreakForever
Copy link
Author

Hey @ragesoss can you pls guide me, why its causing a coverage run error.

@ragesoss
Copy link
Member

If you inspect the coverage logs, at the end of the Ruby test suite, you can find the details about which tests failed and why. (In this case, they are feature specs that are failing when they reach the UI for the component you changed.) I recommend running those specific tests locally to learn more. If necessary, you can modify the browser configuration in rails_helper.rb to remove the 'headless' option and watch the tests run in your browser to see exactly what is going wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants