Refactor date_picker.jsx from class based to functional component #5891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do those failing specs pass locally for you? |
|
I did the rebasing as you said. But due to some issues related to mariaDB in my local, I am unable to run the localhost.So,no tests are passing. |
|
You should be able to reset the test database to get your local environment back in order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Refactor date_picker.jsx from class based to functional component
Screenshots
Before:
346267506-45f71713-1564-428b-96fa-e83dadca643c.mp4
After:
346267506-45f71713-1564-428b-96fa-e83dadca643c.mp4