-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7. Feature/ordering slides of training module #5930
Open
omChauhanDev
wants to merge
348
commits into
WikiEducationFoundation:Om-Training
Choose a base branch
from
omChauhanDev:feature/ordering-slides-of-training-module
base: Om-Training
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
7. Feature/ordering slides of training module #5930
omChauhanDev
wants to merge
348
commits into
WikiEducationFoundation:Om-Training
from
omChauhanDev:feature/ordering-slides-of-training-module
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leted-revisions-authorship-loading Fix: Resolve authorship data loading hang for deleted revisions
Implemented a new feature to support course URLs with additional suffixes
…5-fix-course-user-specs Fix course user spec for untracked revisions
…eToModernRedux Modernizing Redux Logic with Redux Toolkit (Integrate Redux Toolkit and optimize store configuration)
…boarding-ui Fix onboarding UI
Added a link to the settings page under the 'Useful links' section on the admin page, making it easily accessible for users.
- Prevent changes to the title, institution, and term/when fields for courses that are already linked to an event to maintain integration stability. - Added tooltip message to inform users why these fields cannot be edited.
…sable-field-editing-after-sync Disable editing of title, school and term/when fields after event sync
…ttings-link-from-admin Add link to settings page from admin page
Added functionality to copy training modules when copying a course
Converted add_admin_formComponent from class based to function based
…of WikiSelect component (WikiEducationFoundation#5850) * Convert Wikiselect component from class-based to functional * Converted wikiselect component fom class based to functional * Update Gemfile.lock * Update wiki_select.jsx * Added overlooked comments --------- Co-authored-by: Shiven Ahuja <[email protected]>
Although `service <SERVICE_NAME> start` works to start a process, it won't automatically restart unless enabled with systemctl. Whoops.
…article-views-tooltip#6024 Feature: Add tooltip to Article Views metrics on relevant pages WikiEducationFoundation#6024
This was another bug related to permissions checking and the previous buggy implementation of User#can_edit? when passed an nil course. The permissions logic in AssignmentsController is still pretty messy, and should probably all be redone to use the new Assignment#editable_by? method.
This would have caught the recent permissions bug that broke sandbox URL updating.
omChauhanDev
force-pushed
the
feature/ordering-slides-of-training-module
branch
from
November 6, 2024 20:42
596a1a4
to
9125c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This pr added functionality for reordering training slides.
Screenshots
Before:
Training module page
After:
Training module page
Change Order Modal
Reordering of slides
Result after clicking on 'Save'