Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raised for testing purpose - Contains all code of GSoC 2024 #5946

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

omChauhanDev
Copy link
Contributor

What this PR does

This pr is created for testing all training modification features.
Eg: how they work over production server

omChauhanDev and others added 29 commits June 3, 2024 11:33
…ture/switch-edit-view-mode-in-training

Feature/switch edit view mode in training
…ture/add-module-to-training-library

3. feature/add-module-to-training-library-using-dashboard
…ture/transfer-module-between-categories

4. feature/transferring training modules between categories
…ture/adding-slide-in-training_modules

5. Feature/adding slide in training modules
@ragesoss
Copy link
Member

ragesoss commented Sep 6, 2024

This is an impressive set of functionality.

I've done some initial testing, and there are a few UX problems that I think will need to be fixed before this is ready to deploy.

  • There needs to be a way to edit an existing slide. Since we are not supporting slide deletion, it's important to be able to change the wiki page for an existing slide, so that misconfiguring a new slide will not render the slide slug unusable.
  • The wiki page field should automatically handle input that is a meta.wikimedia.org full URL instead of just a page name. Copying and pasting the full URL from a wiki is a common pattern in the dashboard, and it's not obvious whether a user ought to use a URL or just a page title.

@ragesoss
Copy link
Member

ragesoss commented Sep 6, 2024

I also encountered a JS error when entering 'reorder' mode on an existing module's index page:

TypeError: Cannot read properties of null (reading 'split')
    at DraggableSlide (draggableSlide.jsx:68:1)
    at renderWithHooks (react-dom.development.js:16305:18)
    at mountIndeterminateComponent (react-dom.development.js:20069:13)
    at beginWork (react-dom.development.js:21582:16)
    at beginWork$1 (react-dom.development.js:27421:14)
    at performUnitOfWork (react-dom.development.js:26552:12)
    at workLoopSync (react-dom.development.js:26461:5)
    at renderRootSync (react-dom.development.js:26429:7)
    at recoverFromConcurrentError (react-dom.development.js:25845:20)
    at performSyncWorkOnRoot (react-dom.development.js:26091:20)
    at flushSyncCallbacks (react-dom.development.js:12042:22)
    at eval (react-dom.development.js:25646:13)

@ragesoss ragesoss marked this pull request as draft September 6, 2024 19:53
@omChauhanDev
Copy link
Contributor Author

Fixing this error and also reducing some unnecessary lines of code of 'reordering slides' pr. Then will move on to incorporating the listed changes to make it perfect for deployment.

@omChauhanDev
Copy link
Contributor Author

omChauhanDev commented Sep 17, 2024

sir, where you found this error as, I tried replicating this error in my browser console but found nothing
kindly have a look : Video

@omChauhanDev omChauhanDev marked this pull request as ready for review September 18, 2024 10:47
@omChauhanDev omChauhanDev marked this pull request as draft September 18, 2024 11:18
@omChauhanDev
Copy link
Contributor Author

@ragesoss sir, kindly have a look

@ragesoss
Copy link
Member

Hmm... I still hit that same error. I'm doing this in wiki_education mode, with freshly reloaded training modules, and any time I click 'Change Order' on the index page of one of the YAML-backed modules, it throws a JS error and the React-rendered sidebar disappears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants