Add support to set created mpak file name from CLI #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an existsing -n opti0on that sets the property MpakPath. This value needs to be passed into the method creating the mpak. Default value to null which will t hen automatically assign file name using DateTime.
|
I added a comment regarding code that would force the generated file to have a ".mpak" extension. Not sure if you want to force the extension, or let the user set the extension when they specify a custom mpak file. Users will quickly realise they need to add .mpak to the name when they first run the create command and use -n and don't specify the extension. i.e. |
ctacke
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an existing -n option which sets the property MpakPath. This value needs to be passed into the method creating the mpak. Default value to null which will can be checked to then automatically assign a file name using DateTime.