Improve usage of logger and command exception #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the use of Logger, LoggerFactory, and Console by removing the nullable references which eliminates the need for the null conditional operators. This also creates a new
CommandExceptionthat is able to take inCommandExitCode(formerlyCommandErrors) instead of having to cast tointeverywhere.The one note is if
Consoleis used before theExecuteCommand()method, an exception will be thrown with the message, "The Console property has not yet been initialized. It can only be used within in the ExecuteCommand() method."