LogError when build fails #487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add minimum LogError messages to inform user when 'app run' command exits.
|
thx @doingnz - I'm going to approach this a slightly different way but we'll fix asap |
|
Thanks again @doingnz - we're now throwing the correct exceptions which will also give the correct user feedback. I'm closing this PR but really appreciate the nudge to get this updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimum LogError messages to inform user when 'app run' command exits.
Specifically needed when the project fails to build as the Meadow.CLI simple exits to the command prompt without giving any indication why it stopped. Added others for completeness.