CLI changes required to at least build for VS2022 #498
Conversation
| @@ -4,7 +4,9 @@ | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <ImplicitUsings>enable</ImplicitUsings> | |||
| <Nullable>enable</Nullable> | |||
| <LangVersion>10</LangVersion> | |||
| <LangVersion>10</LangVersion> | |||
| <SignAssembly>true</SignAssembly> | |||
There was a problem hiding this comment.
interesting - I assume this is required for the extension?
There was a problem hiding this comment.
Yes. Assemblies need to be signed.
| // TODO [assembly: InternalsVisibleTo("Meadow.HCom.Integration.Tests")] |
There was a problem hiding this comment.
Can this be uncommented?
There was a problem hiding this comment.
Yes it could be, but then the unit test assembly also needs to be signed.
CartBlanche
force-pushed
the
dominique-MigrateVS2022ExtensionTov2
branch
from
f39a7b7
to
d19404d
Compare
|
Looking at the code changes and the changes for the VS2022 extension ..... we should be close to being able to use the projects in the Meadow.CLI project directly without the need to do any file linking. We also shouldn't need any of the logic changes. The one thing missing is the code signing. |
Do your changes also fix the linked unit test issues that previously also needed to be signed?? |
CartBlanche
force-pushed
the
dominique-MigrateVS2022ExtensionTov2
branch
from
1bc9b67
to
fd39360
Compare
CartBlanche
force-pushed
the
dominique-MigrateVS2022ExtensionTov2
branch
from
66c5ffc
to
de48c49
Compare
…r in the Internals attribute.
No description provided.