Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing partition skip predicate #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Will-Lo
Copy link
Owner

@Will-Lo Will-Lo commented Jun 30, 2022

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #22 (08b3c24) into master (7b29ce2) will decrease coverage by 0.00%.
The diff coverage is 43.75%.

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     46.71%   46.70%   -0.01%     
- Complexity    10424    10437      +13     
============================================
  Files          2080     2082       +2     
  Lines         81305    81453     +148     
  Branches       9072     9090      +18     
============================================
+ Hits          37982    38043      +61     
- Misses        39824    39901      +77     
- Partials       3499     3509      +10     
Impacted Files Coverage Δ
...bblin/cluster/GobblinClusterConfigurationKeys.java 0.00% <ø> (ø)
...pache/gobblin/iceberg/writer/GobblinMCEWriter.java 75.55% <ø> (-0.56%) ⬇️
...n/java/org/apache/gobblin/yarn/YarnHelixUtils.java 23.52% <0.00%> (-3.14%) ⬇️
...apache/gobblin/yarn/event/NewContainerRequest.java 0.00% <0.00%> (ø)
...main/java/org/apache/gobblin/yarn/YarnService.java 14.82% <8.98%> (-0.65%) ⬇️
...kunit/packer/KafkaTopicGroupingWorkUnitPacker.java 38.05% <9.09%> (-2.27%) ⬇️
...pache/gobblin/cluster/GobblinHelixJobLauncher.java 64.84% <16.66%> (-2.37%) ⬇️
...completeness/verifier/KafkaAuditCountVerifier.java 51.16% <25.00%> (-2.69%) ⬇️
.../org/apache/gobblin/cluster/GobblinTaskRunner.java 63.63% <42.85%> (+0.17%) ⬆️
...opy/predicates/ExistingPartitionSkipPredicate.java 50.00% <50.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b29ce2...08b3c24. Read the comment docs.

Currently the hive.dataset.existing.entity.policy.ABORT will not
abort if there is an existing partition. One option to resolve this
is to support the ABORT configuration but that might be backwards
incompatible, so introducing a new skip predicate called
ExistingPartitionSkipPredicate that will skip any partition that
already exists in the target table
@cbrentharris cbrentharris force-pushed the existing-partition-skip-predicate branch from 08b3c24 to 8b09e01 Compare June 30, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants