Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky hive materializer test #23

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Will-Lo
Copy link
Owner

@Will-Lo Will-Lo commented Dec 19, 2022

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@Will-Lo Will-Lo force-pushed the fix-flaky-hive-materializer-test branch from b37b6ed to f39cb21 Compare December 19, 2022 20:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2022

Codecov Report

Base: 43.33% // Head: 47.35% // Increases project coverage by +4.01% 🎉

Coverage data is based on head (99b0194) compared to base (5ae4ec7).
Patch coverage: 46.31% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #23      +/-   ##
============================================
+ Coverage     43.33%   47.35%   +4.01%     
+ Complexity     4807     3404    -1403     
============================================
  Files          1046      682     -364     
  Lines         42074    27176   -14898     
  Branches       4653     3204    -1449     
============================================
- Hits          18234    12869    -5365     
+ Misses        22051    12949    -9102     
+ Partials       1789     1358     -431     
Impacted Files Coverage Δ
...pache/gobblin/configuration/ConfigurationKeys.java 0.00% <ø> (ø)
...a/org/apache/gobblin/dataset/DatasetConstants.java 0.00% <ø> (ø)
.../org/apache/gobblin/service/ServiceConfigKeys.java 0.00% <ø> (ø)
...bblin/cluster/GobblinClusterConfigurationKeys.java 0.00% <ø> (ø)
...pache/gobblin/cluster/GobblinHelixJobLauncher.java 65.36% <0.00%> (-0.26%) ⬇️
...rc/main/java/org/apache/gobblin/MysqlDagStore.java 0.00% <0.00%> (ø)
...bblin/runtime/StateStoreBasedWatermarkStorage.java 0.00% <0.00%> (ø)
...obblin/service/FlowConfigResourceLocalHandler.java 15.68% <0.00%> (-0.16%) ⬇️
...in/service/modules/core/GobblinServiceManager.java 49.00% <0.00%> (-0.60%) ⬇️
...modules/flowgraph/DatasetDescriptorConfigKeys.java 0.00% <ø> (ø)
... and 461 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants