Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to guava 20 #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bump to guava 20 #24

wants to merge 4 commits into from

Conversation

Will-Lo
Copy link
Owner

@Will-Lo Will-Lo commented Apr 7, 2023

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots (if applicable):

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2023

Codecov Report

Patch coverage: 51.05% and project coverage change: +0.27 🎉

Comparison is base (34c20ff) 46.58% compared to head (7414354) 46.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #24      +/-   ##
============================================
+ Coverage     46.58%   46.85%   +0.27%     
- Complexity    10669    10758      +89     
============================================
  Files          2133     2139       +6     
  Lines         83491    84030     +539     
  Branches       9281     9335      +54     
============================================
+ Hits          38893    39374     +481     
- Misses        41039    41073      +34     
- Partials       3559     3583      +24     
Impacted Files Coverage Δ
...pache/gobblin/configuration/ConfigurationKeys.java 0.00% <ø> (ø)
.../apache/gobblin/aws/GobblinAWSClusterLauncher.java 70.47% <ø> (+70.47%) ⬆️
...obblin/data/management/copy/CopyConfiguration.java 86.95% <ø> (ø)
...ta/management/copy/ManifestBasedDatasetFinder.java 80.00% <ø> (ø)
...ta/management/copy/iceberg/BaseIcebergCatalog.java 0.00% <0.00%> (ø)
...management/copy/iceberg/IcebergCatalogFactory.java 0.00% <0.00%> (ø)
.../management/copy/iceberg/IcebergDatasetFinder.java 0.00% <0.00%> (ø)
...ta/management/copy/iceberg/IcebergHiveCatalog.java 0.00% <0.00%> (ø)
...lin/data/management/copy/iceberg/IcebergTable.java 71.87% <0.00%> (-11.77%) ⬇️
...management/partition/CopyableDatasetRequestor.java 35.48% <0.00%> (ø)
... and 76 more

... and 25 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants