Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI tests not fail #535

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Make CI tests not fail #535

merged 10 commits into from
Jan 9, 2024

Conversation

dmunozv04
Copy link
Contributor

Makes tests work again, since the latest ubuntu version doesn't have python3.6 support.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

So tests can run on python 3.6
@aarranz
Copy link
Member

aarranz commented Jan 9, 2024

@dmunozv04, tests are still failing. Any progress on this?

@dmunozv04
Copy link
Contributor Author

@aarranz making tests run again has been a bigger task than it looked, since some selenium methods have changed; but I'll have a commit with the fixes soon

@dmunozv04 dmunozv04 changed the title Changes ubuntu runner to 20.04 Make CI tests not fail Jan 9, 2024
pycrypto
pyScss>=1.3.4,<2.0
pycryptodome
git+https://github.com/Kronuz/pyScss@73559d04 # newest PyScss version, not yet released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why upgrading pyScss?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version on pypi is incompatible with python 3.11
Kronuz/pyScss#428

@aarranz aarranz merged commit 28fec83 into Wirecloud:develop Jan 9, 2024
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2024
@aarranz
Copy link
Member

aarranz commented Jan 9, 2024

Working => merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants