-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI tests not fail #535
Conversation
So tests can run on python 3.6
@dmunozv04, tests are still failing. Any progress on this? |
@aarranz making tests run again has been a bigger task than it looked, since some selenium methods have changed; but I'll have a commit with the fixes soon |
to be able to run on python 3.10+
find_element(By.)
src/requirements.txt
Outdated
pycrypto | ||
pyScss>=1.3.4,<2.0 | ||
pycryptodome | ||
git+https://github.com/Kronuz/pyScss@73559d04 # newest PyScss version, not yet released |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why upgrading pyScss?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version on pypi is incompatible with python 3.11
Kronuz/pyScss#428
Working => merged. |
Makes tests work again, since the latest ubuntu version doesn't have python3.6 support.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to the project: Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...