Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge PCS and LDT #16

Merged
merged 10 commits into from
Nov 26, 2024
Merged

Merge PCS and LDT #16

merged 10 commits into from
Nov 26, 2024

Conversation

recmo
Copy link
Collaborator

@recmo recmo commented Nov 25, 2024

No description provided.

@recmo
Copy link
Collaborator Author

recmo commented Nov 25, 2024

In it's current state this PR adds an initial_statement flag to the parameters and replaces the LDT prover with the regular prover, while keeping the LDT verifier. It passes for --field Field256 but fails for Goldilocks.

@recmo recmo changed the title [WIP] Merge PCS and LDT Merge PCS and LDT Nov 26, 2024
@recmo recmo marked this pull request as ready for review November 26, 2024 06:42
WizardOfMenlo
WizardOfMenlo approved these changes Nov 26, 2024
View reviewed changes
Copy link
Owner

@WizardOfMenlo WizardOfMenlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WizardOfMenlo WizardOfMenlo merged commit b2c5996 into main Nov 26, 2024
1 check passed
@WizardOfMenlo WizardOfMenlo deleted the recmo/merge-ldt branch November 26, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WizardOfMenlo WizardOfMenlo WizardOfMenlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@recmo @WizardOfMenlo