Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a method on Gordon's Stream class to retrieve remaining buffer data #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbrebant
Copy link

Added a method on Gordon's Stream class to retrieve remaining buffer data.

Ping @bchevalier @dyoxyne @cstoquer @cainmartin.

@bchevalier
Copy link
Contributor

you added a method that is not used?

@tbrebant
Copy link
Author

tbrebant commented Dec 1, 2017

Yes, just because it's beautiful😄 !

Joke apart, we are using it in in a tool using JEFF.
Gordon could (should?) be an independent component, no?

@bchevalier
Copy link
Contributor

I think it makes sense.
And how is it included? submodule or npm package with npm releases?

@tbrebant
Copy link
Author

tbrebant commented Dec 1, 2017

Now we just require it.
But at long term we should npm package it, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants