Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "apply transform" to export options #161

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

Peatral
Copy link
Contributor

@Peatral Peatral commented Jul 10, 2024

Added an option to the export options. When disabled (enabled by default) the transform does not get applied during export.

I found myself in a situation where this is quite helpful. When creating vehicles you often have to align positions with bones from the rig. Before exporting I always had to clear the location and reset it after, this solves this. (I have the complete model and moving its way easier to just keep the parts where they belong and don't apply the transform during export)

As it is enabled by default the current behaviour should not change as long as you don't touch the option.

I am open to modify this that you can toggle location, rotation and scale individually for those who need it.

Added an option to the export options. When disabled (enabled by default) the transform does not get applied during export.
@DoctorPresto
Copy link
Contributor

Thanks for the pr! I should have time to give this a proper look over tonight

@Simarilius-uk
Copy link
Contributor

Looks good from a brief read, but I'll let Presto review it properly, one comment, in init, add your name to the authors list at the top :)

@Peatral
Copy link
Contributor Author

Peatral commented Jul 10, 2024

Ok I will add my name :)

I also added finer control over what should be applied and what not.

@DoctorPresto
Copy link
Contributor

Thanks for the pr! I should have time to give this a proper look over tonight!

I actually prefer the original implementation with less control - one of the key ideas of the exporter is to limit the number of options people have to think about - would you mind changing back to the original? I think in general the desired behaviour will be to apply or to not apply, we can always adjust this later if need be

@Simarilius-uk
Copy link
Contributor

unless theres some logic for the workflow you can explain why you'd want only part of it?

@Peatral
Copy link
Contributor Author

Peatral commented Jul 10, 2024

Ok, I will change it back. If it should be needed in the future we know where to find it :)

@DoctorPresto DoctorPresto merged commit 303065d into WolvenKit:main Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants