Fix PHPStan (again) #2416
Closed
Fix PHPStan (again) #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPStan released version 1.10.49 today and managed to break things again... maybe someone should explain semver to them.... Either way, this fixes it. I've favoured ignoring these issues instead of "fixing" them as we were already ignoring a "Result of method * (void) is used" for level 0, which is about the same thing. These methods all `return` the return value of a parent/child method, which can either be `int` or `void`. For code consistency and stability, it is a lot clearer to have these `return` statements in place and it will prevent potential future breakage if the parent/child would start returning a stack pointer. Ref: https://github.com/phpstan/phpstan/releases/tag/1.10.49
dingo-d
approved these changes
Dec 12, 2023
|
We're going to fix this use-case in PHPStan, looks easy enough to fix. |
|
Much appreciated @ondrejmirtes ! |
GaryJones
approved these changes
Dec 12, 2023
That's fine, let's give it a little, but I do have another PR ready to go, which would have a broken build without this, so let's not leave it too long as I think it would probably be good to get 3.1.0 out of the door soonish. |
|
Fixed in PHPStan 1.10.50: https://github.com/phpstan/phpstan/releases/tag/1.10.50 |
|
Thank you @ondrejmirtes ! I've triggered a build on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan released version 1.10.49 today and managed to break things again... maybe someone should explain semver to them....
Either way, this fixes it.
I've favoured ignoring these issues instead of "fixing" them as we were already ignoring a "Result of method * (void) is used" for level 0, which is about the same thing.
These methods all
returnthe return value of a parent/child method, which can either beintorvoid. For code consistency and stability, it is a lot clearer to have thesereturnstatements in place and it will prevent potential future breakage if the parent/child would start returning a stack pointer.Ref: https://github.com/phpstan/phpstan/releases/tag/1.10.49