-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH Actions: Bump codecov/codecov-action from 3 to 4 #2421
GH Actions: Bump codecov/codecov-action from 3 to 4 #2421
Conversation
This is a highly problematic change as CodeCov will now require a dedicated token, even for public repos. See codecov/feedback#112 for further information. |
We can't just add the token as a secret in the repo, and use it in the action? |
We will have to, but so far I've just seen problems reported related to this change. At least, they have made a change to allow tokenless runs for PRs from forks as those don't have access to repo secrets. The short of it is that CodeCov basically has a rate limit issue and instead of solving that, they dump the problem onto their end-users with this change. I suggest we wait a few weeks at the very least before accepting this PR, so CodeCov can at least get the release right. |
Looks like CodeCov is locking down on the use of the v3 action as the builds for #2444 keep failing, no matter how often I retry them. sigh Guess it's time to get the token set up and merge this PR (though I somehow expect more problems after that, but we'll see). |
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
69ab559
to
37ff716
Compare
I've added the token now, both in the repo secrets as well as in the workflow (see this PR). If the build passes, we should probably merge this now. |
Bumps codecov/codecov-action from 3 to 4.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
e0b68c6
fix: show both token uses in readme (#1250)1f9f557
Add all args (#1245)09686fc
Update README.md (#1243)f30e495
fix: update action.yml (#1240)a7b945c
fix: allow for other archs (#1239)98ab2c5
Update package.json (#1238)43235cc
Update README.md (#1237)0cf8684
chore(ci): bump to node20 (#1236)8e1e730
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.19.1 to 6.20.0 ...61293af
build(deps-dev): bump@typescript-eslint/parser
from 6.19.1 to 6.20.0 (#1235)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)