Revert "Use a patch format and support linkTarget of core/button for Pattern Overrides (#58165)
#58489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
requested review from
spacedmonkey,
kevin940726,
Mamaduka and
ajitbohra
as code owners
talldan
added
[Type] Task
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/compat/wordpress-6.5/block-bindings/sources/pattern.php ❔ lib/compat/wordpress-6.5/blocks.php |
|
Size Change: -66 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
talldan
requested review from
gziolo,
glendaviesnz,
artemiomorales and
SantosGuillamot
kevin940726
approved these changes
Jan 31, 2024
|
Flaky tests detected in 2a657f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7723669946
|
|
Should we, maybe in a follow-up PR, hide the 
|
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: ecf8037 |
cbravobernal
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Proposes reverting #58165. See the PR discussion for more details.
The aim is to bring gutenberg in line with what's being shipped in WordPress core.
Testing Instructions
Note: any existing patterns created using the patch format probably will cease working. That format was never released, so to test you'll need to create a new pattern.