-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BlockIcon Storybook stories #67186
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @im3dabasia! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
- Demonstrate various icon rendering scenarios
36638b8
to
7baf454
Compare
Hey @t-hamano , When you have a moment, please review my work and give me feedback on it. Thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
To make the story clearer, it would be a good idea to define the type of the props via the meta.argTypes.{propName}.table.type.summary
field. Some components already have types defined, so you should be able to use them as a reference.
packages/block-editor/src/components/block-icon/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-icon/stories/index.story.js
Outdated
Show resolved
Hide resolved
Hey @t-hamano, Thank you for the review. I really appreciate it! I have made the requested changes and was wondering if I could raise a separate PR to update the README.md for this component, as it lacks information about the props. What are your thoughts on this? |
packages/block-editor/src/components/block-icon/stories/index.story.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/block-icon/stories/index.story.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
Related issue: #67165
Screenshots or screencast
Screen.Recording.2024-11-21.at.10.18.45.AM.mov