Details block: remove auto-close behaviour #67766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -24 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
This is a bit better in that I can keep it open to drag and drop but if I try to drag and drop when it's closed, I still don't get a lot of clarity: better.details.movTied to that, I noticed I can't drag and drop above the block when it's the first one within the post content block when writing a new page. I couldn't replicate with the Heading block so thought I'd mention it in case it's unique to the Details block: yes.i.can.mov |
Mamaduka
approved these changes
Dec 10, 2024
Mamaduka
force-pushed
the
remove/details-auto-close
branch
from
66ede25 to
636374a
Compare
|
Flaky tests detected in 636374a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12749872443
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes the auto-close behaviour. Currently the details blocks automatically collapses when selection is moved away.
Why?
Fixes #51247.
It makes it impossible to drag blocks into the details block. I also find it quite distracting that the layout shifts when you select the details block. It seems much better to let the user decide when to open and close it.
How?
Remove the condition and instead add local state connected to clicking the summary element.
Testing Instructions
Insert a details block. Drag blocks into it.
Testing Instructions for Keyboard