Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody #67976

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody #67976

wants to merge 5 commits into from
+86 −51

Conversation

rinkalpagdar
Copy link
Contributor

Part of #67813
Fixes #67943

Testing Instructions

  • Add Next post block
  • Open the settings panel

Screenshots or screencast

|Before|After|
|before-next-post|after-next-post|

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rinkalpagdar <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@fabiankaegy fabiankaegy added [Block] Post Navigation Link Affects the Post Navigation Link Block [Type] Enhancement A suggestion for improvement. labels Dec 13, 2024
@rinkalpagdar
Copy link
Contributor Author

Hello @fabiankaegy I have implemented your suggestion. Thanks for the feedback.

t-hamano
t-hamano reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've left some feedback so I'd be happy if you could check it out.

packages/block-library/src/post-navigation-link/edit.js Outdated Show resolved Hide resolved
packages/block-library/src/post-navigation-link/edit.js Show resolved Hide resolved
packages/block-library/src/post-navigation-link/edit.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano left review comments

@fabiankaegy fabiankaegy fabiankaegy requested changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
[Block] Post Navigation Link Affects the Post Navigation Link Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Next Post block to use ToolsPanel instead of PanelBody
3 participants
@rinkalpagdar @fabiankaegy @t-hamano