Media & Text: Optimize block editor store subscriptions #68290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Dec 25, 2024
Comment on lines
+203
to
+215
| const { image } = useSelect( | ||
| ( select ) => { | ||
| return { | ||
| image: | ||
| mediaId && isSelected | ||
| ? select( coreStore ).getMedia( mediaId, { | ||
| context: 'view', | ||
| } ) | ||
| : null, | ||
| }; | ||
| }, | ||
| [ isSelected, mediaId ] | ||
| ); |
There was a problem hiding this comment.
Just a cosmetic change collocates "similar" hooks.
Mamaduka
changed the title
|
Size Change: +61 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 6f3cc52. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12493546312
|
Mamaduka
commented
Dec 25, 2024
| return ( | ||
| <ResolutionTool | ||
| value={ value } | ||
| defaultValue={ DEFAULT_MEDIA_SIZE_SLUG } |
There was a problem hiding this comment.
Ensures value is correctly reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Similar to #56967.
PR updates the Media & Text block to only subscribe to media resolution settings for the selected block.
Why?
This is a micro-optimization. Every useSelect added to a frequently used block degrades the load and type bit. Since block usage is project-specific, it's better to promote best practices.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast