Site Logo: Prevent uploading multiple images via drag and drop #68618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +33 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jan 13, 2025
|
Thanks, @t-hamano!
Yes, let's update the featured image as well. If we spot more cases, we might want to consider a general solution. cc @swissspidy |
|
We can add a |
|
@Mamaduka Hmm this would benefit from an issue to discuss a more generalized solution vs. just changing this one off block. There are many different places:
It's definitely a bit unexpected to upload multiple files when actually only 1 ends up being visible in the respective block/panel. But should this really throw a hard error? Should this just (silently or with a warning) drop the excessive images instead? I think that would be good to define in an issue. |
|
@swissspidy, thank you for the feedback. I'll create a separate issue, and we can continue the discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR adds a check to the
onFilesDropcallback and prevents multiple image uploads via drag and drop.Why?
The block can only use a single image as the site logo.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast