Use the keyword
field for tags in related query
#3346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Follow up for #3307
Description
The related query uses the
terms
query to match the tags. It was, however, using atext
field (tags.name
) instead of akeyword
field(tags.name.keyword
), which is bad for performance1. This PR fixes it by adding the.keyword
suffix to the query. The tests are updated accordingly.Setting the priority to high because this needs to be deployed together with the other changes to the related query in #3307.
Testing Instructions
CI passing is a good indication that the change is correct because we have the tests for the related endpoint.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin
Footnotes
Why you should avoid using
text
fields forterm
query ↩