Update @openverse/eslint-plugin

[openverse-bot]

This PR contains the following updates:

Package	Type	Update	Change
@swc/cli ([source](https://togithub.com/node ./bin))	devDependencies	minor	^0.1.62 -> ^0.3.0
eslint-plugin-playwright	dependencies	minor	^0.21.0 -> ^0.22.0

---

Release Notes

node%20./bin (@​swc/cli)

v0.1.65

Compare Source

playwright-community/eslint-plugin-playwright (eslint-plugin-playwright)

v0.22.2

Compare Source

Bug Fixes

• Add toPass to missing-playwright-await test matchers (#​206) (3a8f674)
• Fix prefer-to-have-count false positive (510e71c), closes #​207
• Use checked property of toBeChecked when it is not a boolean literal (3563148), closes #​205

v0.22.1

Compare Source

Bug Fixes

• Remove accidental console log (11ac823)

v0.22.0

Compare Source

Bug Fixes

• Ignore expect without assertion in missing-playwright-await (#​201) (47249ce)

Features

• Add no-wait-for-selector rule (#​198) (5bc943f)

---

Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by Renovate Bot.

[AetherUnbound]

I'm not sure what's going on with the linting on this PR - @WordPress/openverse-frontend anyone with more npm expertise, do you know what might be happening?

[sarayourfriend]

It's almost certainly an issue with the "minor" update to swc cli. I'll review the changelog and see if anything stands out. That kind of error is almost always a compilation configuration issue. ESLint is exceptionally picky with how plugin code is emitted.

[sarayourfriend]

It's passing for me locally, so I'm going to rebase this and push again to see if it was just a flaky issue. Maybe the lint files step didn't get the updated dependencies, somehow? 🤔

[sarayourfriend]

Oh wait, actually the plugin isn't building for me locally:

➜ openverse git:(gha-renovate@openverseeslint-plugin) pnpm run postinstall

[email protected] postinstall /home/sara/projects/openverse
pnpm --filter ./packages/* run build

No projects matched the filters in "/home/sara/projects/openverse"

Debugging this now.

[sarayourfriend]

The build step did work for preeslint but not for postinstall. I don't know if the change will fix anything, but I can't reproduce the issue locally, and am in fact getting a totally different behaviour that I can't explain: ESLint is running the rule I introduced in #3725, which isn't merged 😕

[openverse-bot]

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

[sarayourfriend]

It turns out swc is putting output in dist/src instead of dist 😱 luckily, it is mentioned here, and there's a configuration fix to go back to the expected behaviour: swc-project/swc#4017 (comment)

[sarayourfriend]

Alright, so just to confirm, the root cause of the issue was a change in swc to preserve the file tree when passed a directory inside the output directory. So building src with output to dist, now defaults to outputting in dist/src instead of directly in dist. The changes added in the last commit on this PR add flags to the swc invocation so that it outputs directly to dist.

[sarayourfriend]

This is ultimately the necessary fix, but the changes to postinstall and preeslint in the root package.json make things consistent with pnpm docs.

[AetherUnbound]

What a find, thanks for fixing that Sara!