Fix the skip-to-content link reloading the results #3942
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3940 by @sarayourfriend
Description
This PR converts the skip-to-content link to an
a
anchor link instead of using theVLink
component because this component links to a hash#content
URL, andVLink
introduces unnecessary complexity for it.To stop the media re-loading when clicking on
skip-to-content
, I added a check for hash in thesearch.ts
middleware. We don't update anything in the middleware if the navigation was caused by a hash change.Testing Instructions
Try searching for something, and then use Tab to focus the Skip-to-content button, click on the button to navigate to content. You should not see the media reload or the content links change number of results.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin