Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency pook to v2.1.2 #5231

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

openverse-bot
Copy link
Collaborator

@openverse-bot openverse-bot commented Dec 2, 2024

This PR contains the following updates:

Package Type Update Change
pook dev-packages major ~=1.0 -> ~=2.1
pook minor ==2.0.0 -> ==2.1.2

Release Notes

h2non/pook (pook)

v2.1.2

Compare Source

v2.1.1

Compare Source

v2.1.0

Compare Source

  • Drop support for Python 3.8 (it is EOL 2024-10-07)

v2.0.1

Compare Source

v2.0.0

Compare Source

See https://github.com/h2non/pook/issues/128 for a summary of the breaking changes and how to update your code if you are affected.

  • Breaking change: Remove Response::body's binary parameter and enforce a keyword argument for chunked.

    • The binary parameter is no longer needed since responses are now always byte-encoded in all cases (see below).
    • A keyword argument is now enforced for chunked to ensure unnamed arguments meant for the removed binary parameter cannot be confused as chunked arguments.
  • Only return byte-encoded response bodies, matching the bahviour of all supported client libraries.

    • This is possible because for all supported client libraries, pook mocks the actual response sent to the
      client library over the wire, which will, in all cases, be bytes. Client libraries that support reading
      response content as a string or other formats will continue to work as expected, because they'll always
      be handling bytes from pook.
    • This causes no change to application code for users of pook, except for users of the standard library urllib,
      for which this also fixed a bug where non-bytes bodies were returned by pook in certain cases. This is impossible
      in real application code. If you rely on pook to mock urllib responses and have code that handles non-bytes response
      bodies, that code can be safely deleted (provided the only reason it was there was pook in the first place).
  • Breaking change: Remove Mock::body's binary parameter.

    • This parameter was already unused due to a bug in the code (it was not passed through to the BodyMatcher),
      so this will not cause any changes to tests that relied on it: it didn't do anything to begin with.
    • The breaking change is simply the removal of the unused parameter, which should be deleted from tests using pook.
    • Pook's code has also been updated to remove all cases where non-bytes objects were being handled. Instead, the body
      of any interecepted request will always be stored as bytes, and only decoded when necessary for individual downstream
      matchers (JSON, XML).
  • Correct documentation strings for XMLMatcher and JSONMatcher to no longer suggest they can handle regex matchers.

    • These classes never implemented regex matching.
  • Add a pytest fixture to the package.


Configuration

📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot requested review from a team as code owners December 2, 2024 09:41
@openverse-bot openverse-bot added dependencies Pull requests that update a dependency file 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Dec 2, 2024
@openverse-bot openverse-bot removed the request for review from a team December 2, 2024 09:41
@openverse-bot openverse-bot added the 🧱 stack: ingestion server Related to the ingestion/data refresh server label Dec 2, 2024
@krysal krysal merged commit 6dd8d42 into main Dec 3, 2024
46 checks passed
@krysal krysal deleted the gha-renovatepook-2.x branch December 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: ingestion server Related to the ingestion/data refresh server 🐍 tech: python Involves Python
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants