Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .env.sentry-build-plugin for Sentry auth token #5292

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Dec 19, 2024

Fixes

Follow up on #5284

Description

This PR uses the .env.sentry-build-plugin file that is expected by the plugins that build Sentry module for the server (rollup for nitro and vite for nuxt) to provide the auth token. Simply adding the env variable did not work.

Testing Instructions

See that the release worked on the commit that added pull_request to the conditions.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: frontend Related to the Nuxt frontend labels Dec 19, 2024
Copy link

github-actions bot commented Dec 19, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 404      ✗ 0   
     data_received..................: 95 MB   396 kB/s
     data_sent......................: 53 kB   221 B/s
     http_req_blocked...............: avg=68.65µs  min=2.36µs   med=4.5µs    max=1.38ms   p(90)=130.9µs  p(95)=418.41µs
     http_req_connecting............: avg=53.92µs  min=0s       med=0s       max=1.34ms   p(90)=91.02µs  p(95)=183.52µs
     http_req_duration..............: avg=155.59ms min=17.13ms  med=98.54ms  max=1.05s    p(90)=355.17ms p(95)=438.34ms
       { expected_response:true }...: avg=155.59ms min=17.13ms  med=98.54ms  max=1.05s    p(90)=355.17ms p(95)=438.34ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 404 
     http_req_receiving.............: avg=161.4µs  min=62.86µs  med=139.02µs max=669.64µs p(90)=284.19µs p(95)=322.77µs
     http_req_sending...............: avg=35.12µs  min=9.07µs   med=22.37µs  max=3.54ms   p(90)=36.22µs  p(95)=65.62µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=155.39ms min=17.05ms  med=98.39ms  max=1.05s    p(90)=354.87ms p(95)=438.03ms
     http_reqs......................: 404     1.677268/s
     iteration_duration.............: avg=823.32ms min=246.83ms med=867.01ms max=1.76s    p(90)=1.12s    p(95)=1.42s   
     iterations.....................: 77      0.319677/s
     vus............................: 2       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat marked this pull request as ready for review December 19, 2024 05:27
@obulat obulat requested a review from a team as a code owner December 19, 2024 05:27
@obulat obulat requested review from krysal and dhruvkb December 19, 2024 05:27
@obulat obulat merged commit b930ac3 into main Dec 19, 2024
51 checks passed
@obulat obulat deleted the fix/sentry-auth-token branch December 19, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant