Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n-related dependencies #5320

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update i18n-related dependencies #5320

merged 1 commit into from
Jan 7, 2025

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jan 6, 2025

Fixes

This also came out of my attempts to fix Storybook setup (unsuccessful 😢 )

Description

This PR updates the i18n-related dependencies, removes now-unnecessary version overrides, and also groups these dependencies in renovate config.

Testing Instructions

The CI should work, and the translations should be displayed correctly.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 6, 2025
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🧱 stack: mgmt Related to repo management and automations 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 404      ✗ 0   
     data_received..................: 98 MB   406 kB/s
     data_sent......................: 53 kB   220 B/s
     http_req_blocked...............: avg=71.73µs  min=2.23µs   med=5.05µs   max=1.43ms  p(90)=142.24µs p(95)=574.9µs 
     http_req_connecting............: avg=59.82µs  min=0s       med=0s       max=1.39ms  p(90)=95.93µs  p(95)=536.78µs
     http_req_duration..............: avg=177.54ms min=20.41ms  med=104.7ms  max=1.12s   p(90)=417.36ms p(95)=520.16ms
       { expected_response:true }...: avg=177.54ms min=20.41ms  med=104.7ms  max=1.12s   p(90)=417.36ms p(95)=520.16ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 404 
     http_req_receiving.............: avg=182.22µs min=45.68µs  med=150.53µs max=2.02ms  p(90)=292.92µs p(95)=350.81µs
     http_req_sending...............: avg=30.83µs  min=8.03µs   med=23.86µs  max=147.2µs p(90)=45.25µs  p(95)=104.24µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=177.33ms min=20.27ms  med=104.55ms max=1.12s   p(90)=416.99ms p(95)=519.88ms
     http_reqs......................: 404     1.677146/s
     iteration_duration.............: avg=938.93ms min=303.14ms med=940.46ms max=2.05s   p(90)=1.24s    p(95)=1.62s   
     iterations.....................: 77      0.319654/s
     vus............................: 2       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat marked this pull request as ready for review January 6, 2025 17:23
@obulat obulat requested review from a team as code owners January 6, 2025 17:23
@obulat obulat requested review from krysal and dhruvkb and removed request for a team January 6, 2025 17:23
@obulat obulat force-pushed the update/i18n branch 2 times, most recently from 1a1cfb1 to bce1ab9 Compare January 6, 2025 17:46
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes. Do you know why these i18n dependencies were in the repo root earlier?

@obulat
Copy link
Contributor Author

obulat commented Jan 7, 2025

Good changes. Do you know why these i18n dependencies were in the repo root earlier?

That was used to override the versions of peer or child dependencies. There were warnings that putting overrides in the specific repo (frontend) does not work and they need to be in the root. Some i18n dependencies were used in eslint package.

@obulat obulat merged commit c904e47 into main Jan 7, 2025
48 checks passed
@obulat obulat deleted the update/i18n branch January 7, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants