Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close old db connections after getting thumbnails #5335

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Close old db connections after getting thumbnails #5335

merged 1 commit into from
Jan 14, 2025

Conversation

krysal
Copy link
Member

@krysal krysal commented Jan 13, 2025

Fixes

Related to #5334.

Description

This attempts to close the idle db connections by using the django.db.close_old_connections() function1 after getting image thumbnails. Previously, in #5328, it was suggested that the await upstream_response.content.read() call could be the origin of the problem, so I put the db function in a finally block close to it.

Testing Instructions

N/A. CI should pass, and we will see how it behaves in production.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs` for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Footnotes

  1. https://docs.djangoproject.com/en/5.1/ref/databases/#connection-management

@krysal krysal requested a review from a team as a code owner January 13, 2025 18:49
@krysal krysal requested review from obulat and dhruvkb and removed request for a team January 13, 2025 18:49
@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 13, 2025
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Jan 13, 2025
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there are other places, like the dead link filtering, where we need to do the same?

@krysal
Copy link
Member Author

krysal commented Jan 14, 2025

@obulat In principle, I think it should be enough since thumbnails are constantly requested, but it will be interesting to see the graphics after deployment.

@krysal krysal merged commit f41f20d into main Jan 14, 2025
48 checks passed
@krysal krysal deleted the close_conn branch January 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

4 participants