Fix tests for output_buffering setting

WordPress · Aug 16, 2023 · a02c389 · a02c389
1 parent ab9b96f
commit a02c389
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/tests/admin/server-timing-tests.php b/tests/admin/server-timing-tests.php
@@ -57,7 +57,7 @@ public function test_perflab_load_server_timing_page() {
 			array_keys( $wp_settings_fields[ PERFLAB_SERVER_TIMING_SCREEN ] )
 		);
 		$this->assertEqualSets(
-			array( 'benchmarking_actions', 'benchmarking_filters' ),
+			array( 'benchmarking_actions', 'benchmarking_filters', 'output_buffering' ),
 			array_keys( $wp_settings_fields[ PERFLAB_SERVER_TIMING_SCREEN ]['benchmarking'] )
 		);
 	}

diff --git a/tests/server-timing/load-tests.php b/tests/server-timing/load-tests.php
@@ -103,39 +103,43 @@ public function data_perflab_sanitize_server_timing_setting() {
 			),
 			'empty list, array'                           => array(
 				array( 'benchmarking_actions' => array() ),
-				array( 'benchmarking_actions' => array() ),
+				array( 'benchmarking_actions' => array(), 'output_buffering' => false ),
 			),
 			'empty list, string'                          => array(
 				array( 'benchmarking_actions' => '' ),
-				array( 'benchmarking_actions' => array() ),
+				array( 'benchmarking_actions' => array(), 'output_buffering' => false ),
 			),
 			'empty list, string with whitespace'          => array(
 				array( 'benchmarking_actions' => ' ' ),
-				array( 'benchmarking_actions' => array() ),
+				array( 'benchmarking_actions' => array(), 'output_buffering' => false ),
 			),
 			'regular list, array'                         => array(
 				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
-				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
+				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ), 'output_buffering' => false ),
 			),
 			'regular list, string'                        => array(
 				array( 'benchmarking_actions' => "after_setup_theme\ninit\nwp_loaded" ),
-				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
+				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ), 'output_buffering' => false ),
 			),
 			'regular list, string with whitespace'        => array(
 				array( 'benchmarking_actions' => "after_setup_  theme \ninit \n\nwp_loaded\n" ),
-				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
+				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ), 'output_buffering' => false ),
 			),
 			'regular list, array with duplicates'         => array(
 				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded', 'init' ) ),
-				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
+				array( 'benchmarking_actions' => array( 'after_setup_theme', 'init', 'wp_loaded' ), 'output_buffering' => false ),
 			),
 			'regular list, array with special hook chars' => array(
 				array( 'benchmarking_actions' => array( 'namespace/hookname', 'namespace.hookname' ) ),
-				array( 'benchmarking_actions' => array( 'namespace/hookname', 'namespace.hookname' ) ),
+				array( 'benchmarking_actions' => array( 'namespace/hookname', 'namespace.hookname' ), 'output_buffering' => false ),
+			),
+			'output buffering enabled' => array(
+				array( 'output_buffering' => 'on' ),
+				array( 'output_buffering' => true ),
 			),
 			'regular list, disallowed key'                => array(
 				array( 'not_allowed' => array( 'after_setup_theme', 'init', 'wp_loaded' ) ),
-				array(),
+				array( 'output_buffering' => false ),
 			),
 		);
 	}