Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage URL metrics to reserve space for embeds to reduce CLS #1373

Open
wants to merge 56 commits into
base: trunk
Choose a base branch
from
Open

Leverage URL metrics to reserve space for embeds to reduce CLS #1373

wants to merge 56 commits into from

Commits on Aug 17, 2024

  1. Introduce methods to get minumum height of element

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0a376c1 View commit details
    Browse the repository at this point in the history

  2. Set the min-height of an embed prior to it loading

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    8aa7e63 View commit details
    Browse the repository at this point in the history

  3. Set min-height on embed-wrapper instead of figure container

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    11f98f4 View commit details
    Browse the repository at this point in the history

  4. Use 500px as a better representation of an element that could be LCP

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    d7cc7cf View commit details
    Browse the repository at this point in the history

  5. Add test for existing style manipulation

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    48e57e8 View commit details
    Browse the repository at this point in the history

  6. Add helper generator method to get all elements

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0d285f2 View commit details
    Browse the repository at this point in the history

  7. Try using MutationObserve to watch for embed height changes

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    4778a3d View commit details
    Browse the repository at this point in the history

  8. Use the more appropriate ResizeObserver instead of MutationObserver

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    1dbd4a1 View commit details
    Browse the repository at this point in the history

  9. Remove condition that breaks monitoring resizes of post embeds

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    a4bab7e View commit details
    Browse the repository at this point in the history

  10. Introduce client-side Optimization Detective extensions and move Embe… 

    …d Optimizer JS into one
    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    5f0cdbe View commit details
    Browse the repository at this point in the history

  11. Override clientBoundingRect once embed has loaded

    @westonruter
    westonruter committed Aug 17, 2024
    Configuration menu
    Copy the full SHA
    0ba2d6e View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. Move jsdoc types to types.d.ts for reuse

    @westonruter
    westonruter committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    5f4189d View commit details
    Browse the repository at this point in the history

  2. Send URL metric when leaving the page 

    This is an iteration on top of #1098

Co-authored-by: swissspidy <[email protected]>
    @westonruter @swissspidy
    westonruter and swissspidy committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    bf2b3c5 View commit details
    Browse the repository at this point in the history

  3. Use boundingClientRect instead of intersectionRect in get_all_element… 

    …_minimum_heights
    @westonruter
    westonruter committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    b9bad0d View commit details
    Browse the repository at this point in the history

  4. Eliminate timeout for disconneccting ResizeObsever

    @westonruter
    westonruter committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    c6b02ec View commit details
    Browse the repository at this point in the history

  5. Move extension initialization after idle callback

    @westonruter
    westonruter committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    52a2260 View commit details
    Browse the repository at this point in the history

  6. Fix warning when prematurely applying buffered text replacements, esp… 

    …ecially to end-of-body
    @westonruter
    westonruter committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    edc52fa View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Prepend min-height to style attribute instead of appending

    @westonruter
    westonruter committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    820d66d View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Use object spread 

    Co-authored-by: swissspidy <[email protected]>
    @westonruter @swissspidy
    westonruter and swissspidy committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    def2aab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'trunk' of https://github.com/WordPress/performance into… 

    … add/embed-optimizer-min-height-reservation
    @westonruter
    westonruter committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    cd9a618 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Merge branch 'trunk' into add/embed-optimizer-min-height-reservation

    @westonruter
    westonruter authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    02c4fd9 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Use get_json_params() instead of get_params() so _wpnonce query param… 

    … is excluded
    @westonruter
    westonruter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    1da219f View commit details
    Browse the repository at this point in the history

  2. Implement resizedBoundingClientRect extended property in schema

    @westonruter
    westonruter committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    e34d9fe View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Fix testing JSON request

    @westonruter
    westonruter committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5db6f54 View commit details
    Browse the repository at this point in the history

  2. Go back to get_params() by ignoring _wpnonce 

    This is needed because get_json_params() can return null. Also, no need to force the request body to be JSON.

See 1da219f
    @westonruter
    westonruter committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0fa263a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge branch 'trunk' into add/embed-optimizer-min-height-reservation

    @westonruter
    westonruter authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    72b285d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2024

  1. Fix jsdoc

    @westonruter
    westonruter authored Sep 29, 2024
    Configuration menu
    Copy the full SHA
    2a723f7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'trunk' of https://github.com/WordPress/performance into… 

    … add/embed-optimizer-min-height-reservation
    @westonruter
    westonruter committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    71dd914 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Eliminate use of deprecated property

    @westonruter
    westonruter committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    29d4383 View commit details
    Browse the repository at this point in the history

  2. Add breakpoint-specific min-heights to account for responsive embeds

    @westonruter
    westonruter committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a529218 View commit details
    Browse the repository at this point in the history

  3. Add od_generate_media_query() helper

    @westonruter
    westonruter committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    fa8a34e View commit details
    Browse the repository at this point in the history

  4. Break up embed tag visitor into separate methods

    @westonruter
    westonruter committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    1e40f84 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Bump alpha versions

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5d4d5b2 View commit details
    Browse the repository at this point in the history

  2. Add missing short-circuit in case EMBED_OPTIMIZER_VERSION is defined

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5f1c2ac View commit details
    Browse the repository at this point in the history

  3. Rework bootstrap logic to wait until init priority 9 and add od_init … 

    …action for extensions to hook into
    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    915e1e7 View commit details
    Browse the repository at this point in the history

  4. Add test for when resizedBoundingClientRect data not available

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    26ae396 View commit details
    Browse the repository at this point in the history

  5. Remove obsolete short-circuiting now that OD dependency version is ch… 

    …ecked
    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cd80ed1 View commit details
    Browse the repository at this point in the history

  6. Evolve get_all_url_metrics_groups_elements into get_all_denormalized_… 

    …elements
    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    bd008c5 View commit details
    Browse the repository at this point in the history

  7. Add Embed Optimizer tests

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1b5cf13 View commit details
    Browse the repository at this point in the history

  8. Account for error when passing single-item array to min() or max()

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a70df28 View commit details
    Browse the repository at this point in the history

  9. Add test for Image Prioritizer

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4e48d3d View commit details
    Browse the repository at this point in the history

  10. Remove now-unused method to get element minimum hights

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d17cace View commit details
    Browse the repository at this point in the history

  11. Improve handling of get_updated_html

    @westonruter
    westonruter committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5574081 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Add test for get_all_denormalized_elements

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    19c0425 View commit details
    Browse the repository at this point in the history

  2. Add tests for new OD code

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ea36bac View commit details
    Browse the repository at this point in the history

  3. Clarify purpose of overridden get_updated_html method

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    01c083d View commit details
    Browse the repository at this point in the history

  4. Add missing since tags

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c5d6991 View commit details
    Browse the repository at this point in the history

  5. Clarify handling of embed block tags and embed wrapper tags

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    455ef4f View commit details
    Browse the repository at this point in the history

  6. Replace tuple with assoc array 

    Co-authored-by: felixarntz <[email protected]>
    @westonruter @felixarntz
    westonruter and felixarntz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a390e15 View commit details
    Browse the repository at this point in the history

  7. Add doc block for detect.js

    @westonruter
    westonruter committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a760705 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Add API functions to pass to finalize callbacks to avoid direct mutat… 

    …ion of URL Metric object
    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7ca1fbc View commit details
    Browse the repository at this point in the history

  2. Improve error handling

    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f66445f View commit details
    Browse the repository at this point in the history

  3. Harden types and disallow setting core properties

    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6e0aa8e View commit details
    Browse the repository at this point in the history

  4. Reuse sets for reserved property keys

    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9e99e0d View commit details
    Browse the repository at this point in the history

  5. Move functions to root of module

    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    46ba7e3 View commit details
    Browse the repository at this point in the history

  6. Fix TypeScript error related to embedWrapper

    @westonruter
    westonruter committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    0bc521e View commit details
    Browse the repository at this point in the history