Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper function to construct XPath from indexed breadcrumbs #1407

Draft
wants to merge 6 commits into
base: add/embed-optimizer-min-height-reservation
Choose a base branch
from
Draft

Add helper function to construct XPath from indexed breadcrumbs #1407

wants to merge 6 commits into from

Commits on Jul 26, 2024

  1. Introduce methods to get minumum height of element

    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4779d27 View commit details
    Browse the repository at this point in the history

  2. Set the min-height of an embed prior to it loading

    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    947ca41 View commit details
    Browse the repository at this point in the history

  3. Set min-height on embed-wrapper instead of figure container

    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9043c70 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'trunk' of https://github.com/WordPress/performance into… 

    … add/embed-optimizer-min-height-reservation

* 'trunk' of https://github.com/WordPress/performance:
  Move requiring of helper trait to bootstrap
  Reuse populate_url_metrics helper method
  Move duplicated logic into OD test helpers trait
  Output buffer as snapshot as message when assertEquals fails
  Move Optimization Detective test cases into separate files
  Move Embed Optimizer tests cases into separate files
  Move test cases into separate files
    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    aea2082 View commit details
    Browse the repository at this point in the history

  5. Use 500px as width/height for default intersectionRect and boundingCl… 

    …ientRect

This is a more reasonable as a default element size for something which would be LCP.
    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b3ca4ad View commit details
    Browse the repository at this point in the history

  6. Add helper function to construct XPath from indexed breadcrumbs

    @westonruter
    westonruter committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f3e9f1f View commit details
    Browse the repository at this point in the history