Automatically populate wp-cli.local.yml for cli container #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
added
[Type] Enhancement
westonruter
requested review from
mukeshpanchal27,
felixarntz and
thelovekesh
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Interesting 🤔 Not sure where that issue would lie, maybe with the container or the SSH connection? |
|
It's puzzling to me. Here you can see that Screen.recording.2024-09-04.14.37.15.webmThen once I do Ctrl+C, using the mouse scrollwheel causes bash history to be scrolled the same as if I was using Up and Down arrow keys on the keyboard. |
|
Also, hitting |
|
This issue happens in the ChromeOS Terminal app, PhpStorm's built-in terminal, and the GNOME Terminal app. |
|
@westonruter My first guess would be that the SSH connection does not allocate a full TTY, which would mean that interactive features (like pagers) will not work. You can try forcing the allocation of a full TTY by adding the I assume this is WP-CLI executing the actual |
|
Here's the debug output: Details
Of note: |
|
From what I've found so far, it seems like adding the Now, the question is whether this should always be added, or whether we need a separate flag for this. |
|
When I execute this same command without the |
|
I can confirm that adding |
|
Ok, the question then is whether adding the |
|
Should WP-CLI automatically add |
|
wp-cli/wp-cli#5974 looks related |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by @swissspidy's reply to my Tweet (and blog post) about making it easier to run WP-CLI commands in wp-env. He suggests that we could use SSH as the mechanism to connect WP-CLI to the
cliDocker container. After some digging, I found this is possible. However, it is complicated by the fact that the container IDs change every time thatwp-env startruns. So this PR adds a lifecycle script to automatically populate thewp-cli.local.ymlwith the propersshconfig value.When this is done, a globally installed WP-CLI will just work when inside when wp-env is started and the user is inside the repo subdirectory.
It is indeed faster than using
npm run wp-env run cli wp(about twice as fast), however I'm seeing some strange behavior where the pager isn't working. For example, if I dowp --help, I can't scroll down in the text. I have to Ctrl+C to quit the pager (and then the scroll wheel in my Terminal is messed up where it starts scrolling back through my command history instead of scrolling the terminal output).