Strip new PL milestone prefix from milestone title to only have version in changelog #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixarntz
added
[Type] Enhancement
|
@felixarntz Could you please update the command in the handbook? |
mukeshpanchal27
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Now that the PL milestone title format has been changed from just containing the version to "PL Plugin {version}", we need to update the readme script to ensure that it strips that new prefix when generating the changelog.
To test the PR, run
npm run readme -- -m "PL Plugin 2.5.0", and verify that the changelog in the readme only contains "2.5.0", not "PL Plugin 2.5.0".Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.