Fix whitespace not matching in since
command.
#778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the since command was failing to replace instances of
n.e.x.t
when more than once space occurred between the@since
and the placeholder version number, e.g., for docblock alignment purposes.Relevant technical choices
While prepping for the 2.5.0 release, I noticed that running
npm run since -- -r 2.5.0
missed one case in modules/images/fetchpriority/can-load.php that was added during this release. It looks like this is due to the alignment spacing in the docblock, which is causing the regex pattern to not match. Updating the regex pattern to look for multiple spaces and apply the same number of spaces in the replacement fixes the issue.Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.