Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure DRY_RUN to Github Action #780

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Configure DRY_RUN to Github Action #780

merged 3 commits into from
Jul 20, 2023

Conversation

mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Jul 17, 2023 •
edited
Loading

Summary

Fixes #734

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Jul 17, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 17, 2023 06:55
felixarntz
felixarntz approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

Would be great to get @swissspidy's or @joemcgill's feedback as well.

joemcgill
joemcgill approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but nothing blocking. Thanks @mukeshpanchal27!

.github/workflows/deploy-standalone-plugins.yml Show resolved Hide resolved
.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 merged commit 5277953 into trunk Jul 20, 2023
3 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the fix/734-configure-dry-run branch July 20, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcgill joemcgill joemcgill approved these changes

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure DRY_RUN to Github Action
4 participants
@mukeshpanchal27 @joemcgill @swissspidy @felixarntz