-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Fetchpriority module as the functionality is now available in WordPress core #854
Conversation
I understand that the rationale here is that since fetchpriority has landed in WP 6.3, that this plugin is essentially finished software and could be archived. However, we continue to have ongoing conversations about how to improve the heuristics and markup techniques used to accurately apply fetchpriority to the best LCP candidate. For that reason, I wonder if we should keep this plugin in active development as a way of quickly iterating on those improvements prior to them being shipped in an official WP release? |
@joemcgill I thought about this as well before agreeing to remove the module, my conclusion is the following: Yes, we may want to improve the heuristics, but to me this does not fit into this existing module / plugin, as its goal was to enable fetchpriority support. Improving the heuristics affects multiple attributes ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, LGTM!
I had the very same thought when writing my original comment. I'm onboard with that plan. |
Summary
Fixes #853
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.