Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .wordpress-org directory when deploying standalone plugins #866

Merged
merged 5 commits into from
Oct 24, 2023

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #850

I have manually tested the standalone workflow on the forked repository. I have generated a zip file for the plugins and attached it to the summary to verify the process. You can check the following URLs and verify the attached zip:

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Oct 20, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 20, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 20, 2023 05:40
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27 Could we use .gitattributes instead of .distignore, the same way we do for the main plugin?

@mukeshpanchal27
Copy link
Member Author

@felixarntz thanks for the feedback. PR is ready for another round of feedback. Thanks! cc. @joemcgill

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz
Copy link
Member

@mukeshpanchal27 One thing we should test here is to make sure that the module specific .gitattributes files are not part of the main plugin ZIP. We could probably test that with a dry run of the main release workflow.

@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Oct 24, 2023

Thank you, @felixarntz, for bringing this to my attention. I've conducted testing on the main plugin zip through a GitHub action workflow in the forked repository, and it appears that the plugin is exclude the .gitattributes and .wordpress-org files for the module directories.

You can review the workflow here: GitHub Workflow. Once you download the attached performance-lab file, extract it, and subsequently extract the zip generated by the GitHub action, which is meant to be deployed on WordPress.org, you will notice that these excluded files cannot be found.

Screenshot 2023-10-24 at 2 23 24 PM

@swissspidy swissspidy merged commit aec865c into trunk Oct 24, 2023
5 checks passed
@swissspidy swissspidy deleted the fix/850-exclude-directory branch October 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude .wordpress-org directory when deploying standalone plugins
3 participants