-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude .wordpress-org
directory when deploying standalone plugins
#866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Could we use .gitattributes
instead of .distignore
, the same way we do for the main plugin?
@felixarntz thanks for the feedback. PR is ready for another round of feedback. Thanks! cc. @joemcgill |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mukeshpanchal27, LGTM!
@mukeshpanchal27 One thing we should test here is to make sure that the module specific |
Thank you, @felixarntz, for bringing this to my attention. I've conducted testing on the main plugin zip through a GitHub action workflow in the forked repository, and it appears that the plugin is exclude the You can review the workflow here: GitHub Workflow. Once you download the attached |
Summary
Fixes #850
I have manually tested the standalone workflow on the forked repository. I have generated a zip file for the plugins and attached it to the summary to verify the process. You can check the following URLs and verify the attached zip:
Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.