Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement persisting the enabled check categories checkboxes in user settings #304

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Implement persisting the enabled check categories checkboxes in user settings #304

merged 6 commits into from
Oct 26, 2023

Conversation

mukeshpanchal27
Copy link
Member

Closes #299

Checklist:

@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 24, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 24, 2023 11:32
felixarntz
felixarntz requested changes Oct 24, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27 for implementing the PR. It looks great so far, sharing a few points of additional feedback to Pascal's below.

assets/js/plugin-check-admin.js Outdated Show resolved Hide resolved
assets/js/plugin-check-admin.js Show resolved Hide resolved
includes/Admin/Admin_Page.php Outdated Show resolved Hide resolved
templates/admin-page.php Outdated Show resolved Hide resolved
includes/Admin/Admin_Page.php Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Oct 25, 2023
Closed
felixarntz
felixarntz reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, this is almost good to go. Two last points of follow up feedback.

templates/admin-page.php Outdated Show resolved Hide resolved
includes/Admin/Admin_Page.php Outdated Show resolved Hide resolved
@mukeshpanchal27
Copy link
Member Author

@felixarntz @swissspidy, I have addressed all the feedback, and the PR is now ready for review.

felixarntz
felixarntz approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

@felixarntz felixarntz merged commit f526b60 into trunk Oct 26, 2023
12 checks passed
@felixarntz felixarntz deleted the fix/299-save-categories-value branch October 26, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@swissspidy swissspidy swissspidy approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement persisting the enabled check categories checkboxes in user settings
3 participants
@mukeshpanchal27 @swissspidy @felixarntz