Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Fix hero area orphaned text #647

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix hero area orphaned text #647

merged 4 commits into from
Oct 16, 2023

Conversation

richtabor
Copy link
Member

Description

Adjust the content area of the hero, as well as a slight tweak to the font size of the xxl size, so that the hero looks great out of the box across variations.

Screenshots
CleanShot 2023-10-13 at 16 05 27

CleanShot 2023-10-13 at 16 05 44

@richtabor richtabor added the [Type] Bug Something isn't working label Oct 13, 2023
@richtabor richtabor marked this pull request as ready for review October 13, 2023 20:12
@MaggieCabrera
Copy link
Collaborator

Closes #479

@MaggieCabrera
Copy link
Collaborator

I'm not sure what's going wrong here but we are missing vertical alignment somehow. I pushed a change to the formatting of the code cause the diff wasn't clear to me. Let me know if I deleted something important there!

Screenshot 2023-10-16 at 11 09 43 Screenshot 2023-10-16 at 11 09 21

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what was going on here exactly but the layout changes where breaking the spacers so I fixed that. It should be working fine now

@MaggieCabrera MaggieCabrera merged commit 02af139 into trunk Oct 16, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants