Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the "$wordcamp is over. Check out the next edition" text translateable. #1353

Open
wants to merge 3 commits into
base: production
Choose a base branch
from

Conversation

unapersona
Copy link
Contributor

Some strings in the wordcamp.org sites are not translateable.

This PR make the "$wordcamp is over. Check out the next edition", visible in all past WordCamps, translateable.

Screenshots

imagen

@pkevan
Copy link
Contributor

pkevan commented Sep 6, 2024

we probably want to wrap this in wp_kses to avoid anything potentially malicious being added to this. It might be why there wasn't any translations added as it isn't straightforward.

@dd32
Copy link
Member

dd32 commented Oct 15, 2024

we probably want to wrap this in wp_kses to avoid anything potentially malicious being added to this. It might be why there wasn't any translations added as it isn't straightforward.

Generally WordPress (&WordPress.org) trusts translations and relies upon our filters / warnings in translate.wordpress.org for this kinda stuff. There's plenty of "unsafe" __()'s and _e()'s around the WordCamp codebase already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants