This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Add Abort functionality #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding async.Abort, which is an exception that when thrown within a job causes the job to immediately execute with only a logging message and no callbacks executed.
|
@robertkluin-wf @beaulyddon-wf @ericolson-wf |
|
See: #38 |
| @@ -100,6 +100,10 @@ class AlreadyExecutingError(Exception): | |||
| """This Async is currently executing.""" | |||
|
|
|||
|
|
|||
| class Abort(Exception): | |||
| """This Async needs to be aborted immediately.""" | |||
There was a problem hiding this comment.
I would add a further clause here indicating that there will be only a info level log output about the aborted task.
added 4 commits
February 12, 2013 09:15
Add a statement to the Abort docstr indicating that only an info level log message will be output upon Abortion.
In the test_Abort test, I added a check to ensure that Async.start() is not called. Also, I added checks on logging.info() and logging.error() to ensure that info is called and error is not.
Add a logging handler to the root logger that will throw an Exception upon receiving a log message with an Error level or greater level.
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding async.Abort, which is an exception that when thrown within a job
causes the job to immediately execute with only a logging message and no
callbacks executed.