ESG-11074 Don't log bytes / body in the error message #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regenvanwalbeek-wf
force-pushed
the
dontLogBody
branch
from
effdc27 to
ff044a0
Compare
regenvanwalbeek-wf
force-pushed
the
dontLogBody
branch
from
ff044a0 to
59cb593
Compare
evanweible-wf
previously approved these changes
Dec 17, 2024
theisensanders-wf
approved these changes
Dec 17, 2024
regenvanwalbeek-wf
changed the title
maxwellpeterson-wf
approved these changes
Dec 17, 2024
|
@Workiva/release-management-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
toString()of aResponseFormatExceptionproduces a message that contains the contents of the response. This is far too easy for a logging system to dump information that should not be in the logs.Changes
Stop including the body in the ResponseFormatException
Testing/QA Instructions