Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container application building #369

Merged
merged 28 commits into from
Jan 26, 2024
Merged

Container application building #369

merged 28 commits into from
Jan 26, 2024

Commits on Jan 22, 2024

  1. Moved GH workflow reporting into separate job

    @mluypaert
    mluypaert committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    1f73526 View commit details
    Browse the repository at this point in the history

  2. Moved Dockerfile to repo root and API jar build artefact to dedicated… 

    … build directory
    @mluypaert
    mluypaert committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    b6dd309 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Moved git version retrieval to separate target (to enable target call… 

    …ing without)
    @mluypaert
    mluypaert committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    68744da View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Split google secret retrieval into independent ENV targets

    @mluypaert
    mluypaert committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    593601c View commit details
    Browse the repository at this point in the history

  2. Enabled (google) secrets storage and sourcing in Makefile

    @mluypaert
    mluypaert committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    f241ca0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Enabled building ui without nvm usage (for CI/docker context)

    @mluypaert
    mluypaert committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    4ea0c50 View commit details
    Browse the repository at this point in the history

  2. Support building app jar to custom path

    @mluypaert
    mluypaert committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    069ff77 View commit details
    Browse the repository at this point in the history

  3. Make build target naming consistent

    @mluypaert
    mluypaert committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    8a7d6b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Build complete application in Dockerfile. 

    This ensures container building process is build-environment agnostic.
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    bb678e9 View commit details
    Browse the repository at this point in the history

  2. Enable make run using AWS_PROFILE for AWS authentication (DB access)

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1a0ca06 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    1ecec25 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'PR-validation' into container-application-building

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    81ae0cd View commit details
    Browse the repository at this point in the history

  5. Run target naming cleanup

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9037191 View commit details
    Browse the repository at this point in the history

  6. Added .dockerIgnore to reduce docker image build-time and size

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    c2fe52a View commit details
    Browse the repository at this point in the history

  7. Moved datomic bundle download into separate target (for improved repe… 

    …at-performance)
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ffee94e View commit details
    Browse the repository at this point in the history

  8. Prevent accidental secrets leakage

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a7652b4 View commit details
    Browse the repository at this point in the history

  9. Added note to document current issues running run-docker using local DB

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    a494521 View commit details
    Browse the repository at this point in the history

  10. Added container build and run testing to PR validation

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    90e15d9 View commit details
    Browse the repository at this point in the history

  11. Fixed editor mishap

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    b7d1f79 View commit details
    Browse the repository at this point in the history

  12. Allow retrieval of tags for image building in GH actions

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    70e0451 View commit details
    Browse the repository at this point in the history

  13. Prevent errors on cleanup of non-existing containers

    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d7ccfd7 View commit details
    Browse the repository at this point in the history

  14. Ensure container run tests cause correct job failure reporting on ste… 

    …p failure
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8d5eac9 View commit details
    Browse the repository at this point in the history

  15. Fix 2 to ensure container accessability tests cause correct job failu… 

    …re reporting on step failure
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    4ea84b1 View commit details
    Browse the repository at this point in the history

  16. Attempt 3 to fix correct job failure reporting on run-accessability t… 

    …esting step failures
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    9522c49 View commit details
    Browse the repository at this point in the history

  17. Attempt 4 to fix correct job failure reporting on run-accessability t… 

    …esting step failures
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ae20125 View commit details
    Browse the repository at this point in the history

  18. Define default AWS_DEFAULT_REGION value and pass through to container… 

    … at runtime
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    cdf92ab View commit details
    Browse the repository at this point in the history

  19. Attempt to pass through temporary AWS credentials retrieved through r… 

    …oles to application container
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    af9a7ac View commit details
    Browse the repository at this point in the history

  20. Allow more time for application to start up + silenced curl progress … 

    …reporting
    @mluypaert
    mluypaert committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    82b7ca3 View commit details
    Browse the repository at this point in the history